general
- b
brash-tomato-28082
08/11/2021, 8:23 PMit doesn't seem to do any harm, regardless - j
jolly-london-20127
08/11/2021, 8:25 PMhmm yeah I think you're right, probably not useful - j
jolly-london-20127
08/11/2021, 8:25 PMis that where the log is coming from? - b
brash-tomato-28082
08/11/2021, 8:25 PMi don't think so - b
brash-tomato-28082
08/11/2021, 8:25 PMthe command doesn't seem to give any output - b
brash-tomato-28082
08/11/2021, 8:25 PMor exit status - b
brash-tomato-28082
08/11/2021, 8:25 PMit's probably fine to leave in - j
jolly-london-20127
08/11/2021, 8:25 PMI guess on all of these command errors we should be logging something about what command is running - j
jolly-london-20127
08/11/2021, 8:26 PMit's a little difficult with the OS commands. We get a lot of these generic outputs that dont mean anything - b
brash-tomato-28082
08/11/2021, 9:01 PMis there still a use for the netclient-install.slim.sh in the repo? - j
jolly-london-20127
08/11/2021, 9:04 PMNope - b
brash-tomato-28082
08/11/2021, 9:06 PMhi, i was able to make a temporary fix for the issue i was experiencing with netclient - b
brash-tomato-28082
08/11/2021, 9:10 PM - b
brash-tomato-28082
08/11/2021, 9:57 PMthe patch seems to be working well on my vms - j
jolly-london-20127
08/11/2021, 9:59 PMThat's great! Want to submit a PR? - j
jolly-london-20127
08/11/2021, 9:59 PMThat looks like the right way of implementing too - j
jolly-london-20127
08/11/2021, 9:59 PMAs long as it's not throwing an error every checkin (which would break udp hole punching) - b
brash-tomato-28082
08/11/2021, 10:03 PMi looked at the wgctrl documentation and i think the only time SetWGConfig should throw an os.ErrNotExist is this instance - b
brash-tomato-28082
08/11/2021, 10:04 PMwait, would it be better if it were handled in the SetWGConfig funciton instead of the pull funciton? - b
brash-tomato-28082
08/11/2021, 10:13 PMi think it might make more sense that way? - j
jolly-london-20127
08/11/2021, 10:15 PMyou mean running Pull from SetWGConfig? - j
jolly-london-20127
08/11/2021, 10:15 PMyeah - j
jolly-london-20127
08/11/2021, 10:16 PMthat last err catch seems to be a good spot for it - j
jolly-london-20127
08/11/2021, 10:17 PMas long as we dont get caught in a circular loop... - b
brash-tomato-28082
08/11/2021, 10:19 PMi dont think it should get caught because it calls the pull again with manual true - b
brash-tomato-28082
08/11/2021, 10:20 PMand the err catch occurs in the else of the if statement - b
brash-tomato-28082
08/11/2021, 10:20 PMso it shouldnt be able to reach that branch again - j
jolly-london-20127
08/11/2021, 10:20 PMok, yeah that makes sense then - j
jolly-london-20127
08/11/2021, 10:21 PMwell awesome, if you're willing to put up a PR I'd love to get this in a patch - b
brash-tomato-28082
08/11/2021, 10:22 PMAlright, ill put in a pr